Approving & Requesting Changes
3 exercises — write meaningful approvals and clearly explain what must change before a PR can merge.
0 / 3 completed
Approval vs. change request — key phrases
- Approve: "Looks good — tested locally, all tests pass."
- Approve with note: "Approved. One thing to keep in mind for the future: [non-blocking note]."
- Request changes: "A few things need to be addressed before this is ready to merge."
- Scoped approval: "Approved from a [area] perspective — [other team] should also review."
1 / 3
You have reviewed a PR and everything looks good. Which approval comment is the most professional and useful?
Option C is the model approval. It tells the author exactly what you verified (tested locally, existing tests, the specific edge cases), which builds confidence that the review was thorough. It also ends with genuine praise.
"LGTM" has become a shorthand that can mean anything from "I read every line carefully" to "I glanced at the diff". It's fine in a pinch for small changes among close collaborators, but for significant PRs, more detail signals real engagement.
Approval comments should answer: What did you verify? Did you test it? Are there open questions? A 2-sentence approval is always better than a one-word one.
"LGTM" has become a shorthand that can mean anything from "I read every line carefully" to "I glanced at the diff". It's fine in a pinch for small changes among close collaborators, but for significant PRs, more detail signals real engagement.
Approval comments should answer: What did you verify? Did you test it? Are there open questions? A 2-sentence approval is always better than a one-word one.