Listening: US/UK Code Review Call
A code review call between a US and a UK engineer. 3 questions on idioms, spelling conventions (-ise vs -ize), and informal phrases that differ between dialects.
British vs American English — code review vocabulary
- brilliant (UK) = awesome / great (US) — approval
- -ise endings (UK) = -ize endings (US): optimise / optimize
- colour / colour (UK) = color (US) — watch variable names
- crack on (UK) = let's keep going / move on (US)
- cheers (UK) = thanks / goodbye — informal sign-off
0 / 3 completed
1 / 3
On a code review call, the UK engineer says: "Brilliant — the refactor looks clean. I'd just flag one thing: you've used 'colour' in this variable name but the rest of the codebase uses 'color'."
What does "brilliant" signal here, and what practical issue is the engineer raising?
What does "brilliant" signal here, and what practical issue is the engineer raising?
"Brilliant" is a very common British English expression of enthusiasm and approval, equivalent to American English "awesome," "great," or "nice work." It is genuine, not sarcastic, in this context.
The practical issue: colour (UK) vs color (US) is a real problem in codebases with mixed UK/US contributors. Variable names, CSS class names, and comments can become inconsistent.
Best practice: Pick one spelling convention for your codebase (usually American English for code, since most languages and frameworks use it) and use a linter or style guide to enforce it.
The practical issue: colour (UK) vs color (US) is a real problem in codebases with mixed UK/US contributors. Variable names, CSS class names, and comments can become inconsistent.
Best practice: Pick one spelling convention for your codebase (usually American English for code, since most languages and frameworks use it) and use a linter or style guide to enforce it.
.eslintrc and editor settings can catch spelling inconsistencies.